From 2623140c9a1303884cac3a746a08ac113e747514 Mon Sep 17 00:00:00 2001 From: Johannes Nicolai Date: Tue, 16 Feb 2021 01:55:55 +0100 Subject: [PATCH] Make log message less scary (#311) * the reconciliation loop is often much faster than the runner startup, so changing runner not found related messages to debug and also add the possibility that the runner just needs more time --- controllers/runner_controller.go | 2 +- controllers/runnerreplicaset_controller.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/controllers/runner_controller.go b/controllers/runner_controller.go index 606e177e..60e2bbd8 100644 --- a/controllers/runner_controller.go +++ b/controllers/runner_controller.go @@ -250,7 +250,7 @@ func (r *RunnerReconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { if err != nil { var e *github.RunnerNotFound if errors.As(err, &e) { - log.Error(err, "Failed to check if runner is busy. Probably this runner has never been successfully registered to GitHub.") + log.V(1).Info("Failed to check if runner is busy. Either this runner has never been successfully registered to GitHub or it still needs more time.", "runnerName", runner.Name) notRegistered = true } else { diff --git a/controllers/runnerreplicaset_controller.go b/controllers/runnerreplicaset_controller.go index 527c41b9..0ee9fb6f 100644 --- a/controllers/runnerreplicaset_controller.go +++ b/controllers/runnerreplicaset_controller.go @@ -111,7 +111,7 @@ func (r *RunnerReplicaSetReconciler) Reconcile(req ctrl.Request) (ctrl.Result, e var e *github.RunnerNotFound if errors.As(err, &e) { - log.Error(err, "Failed to check if runner is busy. Probably this runner has never been successfully registered to GitHub, and therefore we prioritize it for deletion", "runnerName", runner.Name) + log.V(1).Info("Failed to check if runner is busy. Either this runner has never been successfully registered to GitHub or has not managed yet to, and therefore we prioritize it for deletion", "runnerName", runner.Name) notRegistered = true } else { var e *gogithub.RateLimitError