public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unnecessary scale-target-not-found error on in_progress workflow_job event (#927) 

Ref https://github.com/actions-runner-controller/actions-runner-controller/issues/877#issuecomment-955614456
This commit is contained in:
Yusuke Kuoka 2021-11-09 09:05:50 +09:00 committed by GitHub
parent b305e38b17
commit 2191617eb5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
controllers/horizontal_runner_autoscaler_webhook.go
View File

@ -224,7 +224,7 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) Handle(w http.Respons
labels := e.WorkflowJob.Labels labels := e.WorkflowJob.Labels
switch e.GetAction() { switch action := e.GetAction(); action {
case "queued", "completed": case "queued", "completed":
target, err = autoscaler.getJobScaleUpTargetForRepoOrOrg( target, err = autoscaler.getJobScaleUpTargetForRepoOrOrg(
context.TODO(), context.TODO(),
@ -248,7 +248,13 @@ func (autoscaler *HorizontalRunnerAutoscalerGitHubWebhook) Handle(w http.Respons
} }
} }
default: default:
ok = true
w.WriteHeader(http.StatusOK)
log.V(2).Info("Received and ignored a workflow_job event as it triggers neither scale-up nor scale-down", "action", action)
return
} }
case *gogithub.PingEvent: case *gogithub.PingEvent:
ok = true ok = true