From 1e452358b4d7f2bb0242bfae4d7d65172b496e34 Mon Sep 17 00:00:00 2001 From: Yusuke Kuoka Date: Wed, 16 Feb 2022 11:42:38 +0000 Subject: [PATCH] acceptance: Do recreate the controller-manager secret on every deployment We had to manually remove the secret first to update the GitHub credentials used by the controller, which was cumbersome. Note that you still need to recreate the controller pods and the gh webhook server pods to let them remount the recreated secret. --- acceptance/deploy.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/acceptance/deploy.sh b/acceptance/deploy.sh index fbee5c9d..a1b6d6e7 100755 --- a/acceptance/deploy.sh +++ b/acceptance/deploy.sh @@ -6,6 +6,8 @@ tpe=${ACCEPTANCE_TEST_SECRET_TYPE} VALUES_FILE=${VALUES_FILE:-$(dirname $0)/values.yaml} +kubectl delete secret controller-manager || : + if [ "${tpe}" == "token" ]; then if ! kubectl get secret controller-manager -n actions-runner-system >/dev/null; then kubectl create secret generic controller-manager \