public_git
/
actions-runner-controller
mirror of https://github.com/actions-runner-controller/actions-runner-controller.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Make Runner{Deployment,ReplicaSet} replicas actually optional (#186) 

If omitted, it properly defaults to 1.

Fixes #64
This commit is contained in:
Yusuke Kuoka 2020-11-14 22:06:33 +09:00 committed by GitHub
parent 9a22bb5086
commit 1658f51fcb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
acceptance/testdata/runnerdeploy.yaml vendored
View File

@ -3,7 +3,7 @@ kind: RunnerDeployment
metadata: metadata:
name: example-runnerdeploy name: example-runnerdeploy
spec: spec:
replicas: 1 # replicas: 1
template: template:
spec: spec:
repository: mumoshu/actions-runner-controller-ci repository: mumoshu/actions-runner-controller-ci

1
api/v1alpha1/runnerdeployment_types.go
View File

@ -27,6 +27,7 @@ const (
// RunnerReplicaSetSpec defines the desired state of RunnerDeployment // RunnerReplicaSetSpec defines the desired state of RunnerDeployment
type RunnerDeploymentSpec struct { type RunnerDeploymentSpec struct {
// +optional // +optional
// +nullable
Replicas *int `json:"replicas,omitempty"` Replicas *int `json:"replicas,omitempty"`
Template RunnerTemplate `json:"template"` Template RunnerTemplate `json:"template"`

4
api/v1alpha1/runnerreplicaset_types.go
View File

@ -22,7 +22,9 @@ import (
// RunnerReplicaSetSpec defines the desired state of RunnerReplicaSet // RunnerReplicaSetSpec defines the desired state of RunnerReplicaSet
type RunnerReplicaSetSpec struct { type RunnerReplicaSetSpec struct {
Replicas *int `json:"replicas"` // +optional
// +nullable
Replicas *int `json:"replicas,omitempty"`
Template RunnerTemplate `json:"template"` Template RunnerTemplate `json:"template"`
} }

1
config/crd/bases/actions.summerwind.dev_runnerdeployments.yaml
View File

@ -41,6 +41,7 @@ spec:
description: RunnerReplicaSetSpec defines the desired state of RunnerDeployment description: RunnerReplicaSetSpec defines the desired state of RunnerDeployment
properties: properties:
replicas: replicas:
nullable: true
type: integer type: integer
template: template:
properties: properties:

2
config/crd/bases/actions.summerwind.dev_runnerreplicasets.yaml
View File

@ -41,6 +41,7 @@ spec:
description: RunnerReplicaSetSpec defines the desired state of RunnerReplicaSet description: RunnerReplicaSetSpec defines the desired state of RunnerReplicaSet
properties: properties:
replicas: replicas:
nullable: true
type: integer type: integer
template: template:
properties: properties:
@ -1533,7 +1534,6 @@ spec:
type: object type: object
type: object type: object
required: required:
- replicas
- template - template
type: object type: object
status: status: