From 60d172f05765c659730e82dd81fa448679a34314 Mon Sep 17 00:00:00 2001 From: ElVit Date: Mon, 9 Jun 2025 10:24:06 +0200 Subject: [PATCH] Replaced setPlus73 with setPlus1 --- components/panasonic_heatpump/commands.cpp | 19 +++++++------------ components/panasonic_heatpump/commands.h | 1 - .../panasonic_heatpump/panasonic_heatpump.cpp | 2 +- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/components/panasonic_heatpump/commands.cpp b/components/panasonic_heatpump/commands.cpp index 9c30a53..d554f80 100644 --- a/components/panasonic_heatpump/commands.cpp +++ b/components/panasonic_heatpump/commands.cpp @@ -48,32 +48,32 @@ namespace esphome uint8_t PanasonicCommand::setMultiply2(size_t input) { - return input * 2; + return input * 0b10; } uint8_t PanasonicCommand::setMultiply4(size_t input) { - return input * 4; + return input * 0b100; } uint8_t PanasonicCommand::setPlus1Multiply4(size_t input) { - return (input + 1) * 4; + return (input + 1) * 0b100; } uint8_t PanasonicCommand::setPlus1Multiply8(size_t input) { - return (input + 1) * 8; + return (input + 1) * 0b1000; } uint8_t PanasonicCommand::setPlus1Multiply16(size_t input) { - return (input + 1) * 16; + return (input + 1) * 0b10000; } uint8_t PanasonicCommand::setPlus1Multiply64(size_t input) { - return (input + 1) * 64; + return (input + 1) * 0b1000000; } uint8_t PanasonicCommand::setPlus1(size_t input) @@ -81,14 +81,9 @@ namespace esphome return input + 1; } - uint8_t PanasonicCommand::setPlus73(size_t input) - { - return input + 73; - } - uint8_t PanasonicCommand::setPlus128(size_t input) { - return input + 128; + return input + 0b10000000; } uint8_t PanasonicCommand::setOperationMode(size_t input) diff --git a/components/panasonic_heatpump/commands.h b/components/panasonic_heatpump/commands.h index 09aa48f..ad7df8b 100644 --- a/components/panasonic_heatpump/commands.h +++ b/components/panasonic_heatpump/commands.h @@ -25,7 +25,6 @@ namespace esphome static uint8_t setPlus1Multiply16(size_t input); static uint8_t setPlus1Multiply64(size_t input); static uint8_t setPlus1(size_t input); - static uint8_t setPlus73(size_t input); static uint8_t setPlus128(size_t input); static uint8_t setOperationMode(size_t input); static uint8_t temp2hex(float temp); diff --git a/components/panasonic_heatpump/panasonic_heatpump.cpp b/components/panasonic_heatpump/panasonic_heatpump.cpp index 5461378..b39d1e9 100644 --- a/components/panasonic_heatpump/panasonic_heatpump.cpp +++ b/components/panasonic_heatpump/panasonic_heatpump.cpp @@ -749,7 +749,7 @@ namespace esphome { if (object == this->set2_select_) this->set_command_byte(PanasonicCommand::setPlus1Multiply16(value), 5); else if (object == this->set3_select_) this->set_command_byte(PanasonicCommand::setPlus1Multiply8(value), 7); - else if (object == this->set4_select_) this->set_command_byte(PanasonicCommand::setPlus73(value), 7); + else if (object == this->set4_select_) this->set_command_byte(PanasonicCommand::setPlus1(value), 7); else if (object == this->set9_select_) this->set_command_byte(PanasonicCommand::setOperationMode(value), 6); else if (object == this->set17_select_) this->set_command_byte(PanasonicCommand::setPlus1Multiply64(value), 6); else if (object == this->set26_select_) this->set_command_byte(PanasonicCommand::setPlus1Multiply16(value), 25);